On 10 Jul 2003, Alexander Pohoyda wrote:
> > > > > http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff
> > > > Can you elaborate on why is it useful to switch from single quote
> > > > quoting to backslashes?
> > > It may be not useful as much, but with an old version we end up
> > > calling a command:
> > > [...] cc -c [...] -DHAS_MKSTEMP
> > > '-DSYSTEM_INIT_FILE="'/usr/X11R6/lib/X11/twm'/system.twmrc"' parse.c
> > > which is not consistent, does not look very nice and requires more
> > > processing by the shell.
> > ... but is still required for portability reasons.
> Oh! Good to know. Thanks.
> May I also ask on which system/shell/compiler/imake would my patch fail?
> Just for the record.
With your change, on IRIX, I get:
[aurora:/scratch_large/root/X11/alpha/loader/xc/programs] make SUBDIRS=twm Makefiles
making Makefiles in programs/twm...
mv -f Makefile Makefile.bak
cc-1018 cc: ERROR at end of source
An unmatched left parentheses "(" appears in an expression.
cc-1247 cc: ERROR File = ./Imakefile, Line = 27
The macro invocation is improperly terminated.
SpecialCObjectRule(parse,$(_NOOP_),-DSYSTEM_INIT_FILE=\"$(TWMDIR)/system.twmrc\")
^
2 errors detected in the compilation of "Imakefile.c".
../../config/imake/imake: Exit code 2.
Stop.
*** Error code 1 (bu21)
UX:make: ERROR: make: file `Makefile' line 5: Must be a separator (: or ::) for rules
(bu39)
UX:make: ERROR: make: file `Makefile' line 5: bad character > (octal 76)
[aurora:/scratch_large/root/X11/alpha/loader/xc/programs]
> I'm wondering how this can work then:
> ./xc/programs/xkbcomp/Imakefile:ROOT_DEFINES =
> -DDFLT_XKB_CONFIG_ROOT=\"$(LIBDIR)/xkb\"
> ./xc/programs/xdm/Imakefile:RANDOM_DEFINES = -DDEV_RANDOM=\"/dev/urandom\"
Those are not macro expansions (in the cpp sense).
Marc.
+----------------------------------+-----------------------------------+
| Marc Aurele La France | work: 1-780-492-9310 |
| Computing and Network Services | fax: 1-780-492-1729 |
| 352 General Services Building | email: [EMAIL PROTECTED] |
| University of Alberta +-----------------------------------+
| Edmonton, Alberta | |
| T6G 2H1 | Standard disclaimers apply |
| CANADA | |
+----------------------------------+-----------------------------------+
XFree86 Core Team member. ATI driver and X server internals.
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel
