Marc Aurele La France <[EMAIL PROTECTED]> writes:

> http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff

Updated.


> > > > > Can you elaborate on why is it useful to switch from single quote
> > > > > quoting to backslashes?
> 
> > > > It may be not useful as much, but with an old version we end up
> > > > calling a command:
> > > > [...] cc -c [...] -DHAS_MKSTEMP  
> > > > '-DSYSTEM_INIT_FILE="'/usr/X11R6/lib/X11/twm'/system.twmrc"' parse.c
> > > > which is not consistent, does not look very nice and requires more
> > > > processing by the shell.
> 
> > > ... but is still required for portability reasons.
> 
> > Oh! Good to know. Thanks.
> > May I also ask on which system/shell/compiler/imake would my patch fail?
> > Just for the record.
> 
> With your change, on IRIX, I get:
> 
> [aurora:/scratch_large/root/X11/alpha/loader/xc/programs] make SUBDIRS=twm Makefiles
> making Makefiles in programs/twm...
>         mv -f Makefile Makefile.bak
> cc-1018 cc: ERROR at end of source
>   An unmatched left parentheses "(" appears in an expression.

Would you please try if it works on IRIX this way:

-SpecialCObjectRule(parse,$(_NOOP_),'-DSYSTEM_INIT_FILE="'$(TWMDIR)'/system.twmrc"')
+SpecialCObjectRule(parse,$(_NOOP_),'-DSYSTEM_INIT_FILE="$(TWMDIR)/system.twmrc"')


It's not about commiting this senseless patch, of course :-)
Thank you very much!


-- 
Alexander Pohoyda
<[EMAIL PROTECTED]>
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel

Reply via email to