On Thu, Dec 17, 2009 at 10:52:35AM +0000, Nicholas Clark wrote: > Would it be OK for me to apply the following patch?
Sure, go ahead. > It moves the call to normalize_eval_seqn() after the callback runs. > With this change, it's possible to write a program to output a byte-for-byte > identical file via the callback interface. I'm curious about why you might want to do that. > Without it, it's not, because the callback gets passed the normalised > subroutine names, rather than the originals. > > No tests fail with it, but I wasn't sure if there was an architectural reason > why the callback should have the normalised name. I don't think so. It depends on the use-case I guess and the use-cases for callbacks have been fuzzy/exploratory. Anyone who needs a normalized name can use a regex that does the same as normalize_eval_seqn(). I prefer to throw away as little information as possible, so the change seems good to me. Thanks! Tim. -- You've received this message because you are subscribed to the Devel::NYTProf Development User group. Group hosted at: http://groups.google.com/group/develnytprof-dev Project hosted at: http://perl-devel-nytprof.googlecode.com CPAN distribution: http://search.cpan.org/dist/Devel-NYTProf To post, email: [email protected] To unsubscribe, email: [email protected]
