On Thu, Dec 17, 2009 at 09:13:44PM +0000, Tim Bunce wrote:
> On Thu, Dec 17, 2009 at 05:08:11PM +0000, Nicholas Clark wrote:

> > +     NEW_FID => sub {
> > +    my (undef, $fid, $eval_fid, $eval_line, $flags, $size, $mtime, $name) 
> > = @_;
> > +    my ($new_fid, $new_eval_fid);
> > +    if($eval_fid) {
> > +        $new_eval_fid = $fids{$eval_fid};
> > +        confess("unknown eval_fid $eval_fid") unless defined $new_eval_fid;
> > +        $new_fid = $next_fid++;
> > +        $fids{$fid} = $new_fid;
> > +    } else {
> > +        $new_eval_fid = $eval_fid;
> > +        $new_fid = $file_to_fid{$name};
> 
> I'd add $size and $mtime to the key (not used yet, but this'll make them
> more important).

I was thinking that if either differ, it should croak, as otherwise it's
indicative of trying to merge profiles of different versions, which I
assume would be incompatible.

[The rest I can't answer until tomorrow]

Nicholas Clark

-- 
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.

Group hosted at:  http://groups.google.com/group/develnytprof-dev
Project hosted at:  http://perl-devel-nytprof.googlecode.com
CPAN distribution:  http://search.cpan.org/dist/Devel-NYTProf

To post, email:  [email protected]
To unsubscribe, email:  [email protected]

Reply via email to