On May 26, 2014, at 12:24 PM, Laurent Birtz <[email protected]> wrote:
> Hi,
>
> the patch looks good to me. I flagged some minor stuff but I don't think that
> further review is required to commit the patch.
>
> Thanks,
> Laurent
> <tiles.patch>
Hi,
I fixed the minor stuff. I’ll commit in a couple of minutes.
Regarding the UNIX file format, I don’t know what happened. vim doesn’t mention
any file being in DOS format. I double checked my system and everything looks
fine. In fact, I checked the files using three different checks. As you can see
below, everything is in order.
# Create a simple file (UNIX file format).
$ echo 'Hello, World!' > unix.txt
# Display file info.
$ file unix.txt
unix.txt: ASCII text
# UNIX to DOS end-of-line conversion.
$ awk '{sub("$","\r\n"); print $0}' unix.txt > dos.txt
# Display file info. Notice the CRLF flag.
$ file dos.txt
dos.txt: ASCII text, with CRLF, LF line terminators
# Count carriage return occurrences (UNIX file format).
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' unix.txt
0
# Count carriage return occurrences (DOS file format).
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' dos.txt
1
# Count carriage return occurrences (UNIX file format).
$ tr -cd '\r' < dos.txt | wc -c
1
# Count carriage return occurrences (DOS file format).
$ tr -cd '\r' < unix.txt | wc -c
0
# Check all patched files.
$ file f265/bdi.c
f265/bdi.c: ASCII C++ program text
$ file f265/bdi.h
f265/bdi.h: ASCII C++ program text
$ file f265/bs.c
f265/bs.c: ASCII C++ program text
$ file f265/enc.c
f265/enc.c: ASCII C++ program text
$ file f265/enc.h
f265/enc.h: ASCII C++ program text
$ file f265/f265.h
f265/f265.h: ASCII C++ program text
$ file f265/parse.c
f265/parse.c: ASCII C++ program text
$ tr -cd '\r' < doc/params.txt | wc -c
0
$ tr -cd '\r' < f265/bdi.c | wc -c
0
$ tr -cd '\r' < f265/bdi.h | wc -c
0
$ tr -cd '\r' < f265/bs.c | wc -c
0
$ tr -cd '\r' < f265/enc.c | wc -c
0
$ tr -cd '\r' < f265/enc.h | wc -c
0
$ tr -cd '\r' < f265/f265.h | wc -c
0
$ tr -cd '\r' < f265/parse.c | wc -c
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' doc/params.txt
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' f265/bdi.c
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' f265/bdi.h
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' f265/bs.c
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' f265/enc.c
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' f265/enc.h
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' f265/f265.h
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' f265/parse.c
0
$ perl -nle 'BEGIN{$n=0};$n++ if m{\r$}g;END{print $n}' ~/Desktop/tiles.patch
0
Regards,
François
--
To unsubscribe visit http://f265.org
or send a mail to [email protected].
