asomers commented on this pull request.
> get_metaslab_refcount(vdev_t *vd)
{
int refcount = 0;
if (vd->vdev_top == vd && !vd->vdev_removing) {
- for (int m = 0; m < vd->vdev_ms_count; m++) {
+ for (unsigned int m = 0; m < vd->vdev_ms_count; m++) {
Some loops require unsigned indices, and some require signed. In this case,
`m` must be unsigned because we compare it to `vd->vdev_ms_count`, which is
`uint64_t`. OTOH, near the bottom of `main`, `i` must be signed because we
compare it to `argc`, which is signed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/354#discussion_r118054242
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox-beta.com/groups/developer/discussions/T95949071eb220b14-Ma8f1e9d51580003fc05f081f
Powered by Topicbox: https://topicbox-beta.com
