asomers commented on this pull request.
> @@ -39,7 +39,7 @@ extern "C" {
* particular object, use FTAG (which is a string) for the holder_tag.
* Otherwise, use the object that holds the reference.
*/
-#define FTAG ((char *)__func__)
+#define FTAG ((char *)(uintptr_t)__func__)
Otherwise:
```
cast from 'const char *' to 'char *' drops const qualifier
[-Werror,-Wcast-qual]
VERIFY3U(0, ==, dmu_bonus_hold(os, obj, FTAG, &db));
^
```
I suppose a better solution might be for `FTAG` to cast to a `const char*`, but
that doesn't work because too many functions, like `dmu_bonus_hold`, expect a
non-constant argument. Fixing that would be a more intrusive change.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/354#discussion_r118058746
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T95949071eb220b14-Mfd8ddd45404c745bbddcbf9d
Powered by Topicbox: https://topicbox.com
