@lundman @tcaputi I can't find the exact compilation error, but I think what's 
happening is that SNPRINTF_BLKPTR() now uses BP_IS_ENCRYPTED(), which uses 
dmu_ot, which is defined in dmu.c, which is not compiled into mdb.  This does 
seem like a bit of a mess.

One way to fix it would be to make the mdb module have its own global table for 
dmu_ot.  mdb could fill it in based on what's in the kernel module (see 
zfs_blkstats() for an example, using mdb_readvar()).  We'd have to be sure to 
fill it in before using SNPRINTF_BLKPTR() in mdb.

Alternatively, we could try to find another way for BP_IS_ENCRYPTED() to 
determine if the block is encrypted - perhaps using another bit of the blkptr_t 
(but this might be a pain).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/124#issuecomment-305043636
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T1625245905c55186-Mec3aa83cf83e121722a56aea
Powered by Topicbox: https://topicbox.com

Reply via email to