dankimmel commented on this pull request.

@prakashsurya how do we kick off a new test run for this now? It looks like the 
build failed but the Jenkins output has already been cleaned up.

-               if (!all && HDR_HAS_L2HDR(hdr) &&
-                   (hdr->b_l2hdr.b_daddr > taddr ||
+               /* Ensure this header has finished being written. */
+               ASSERT(!HDR_L2_WRITING(hdr));
+               ASSERT(!HDR_L2_WRITE_HEAD(hdr));
+
+               if (!all && (hdr->b_l2hdr.b_daddr >= taddr ||

Did you mean to change this `>` to `>=` here? (If so could you quickly clarify 
why?)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/305#pullrequestreview-43214309
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T88cf39f4aaf24fbf-M46d23be0fc034ec73c386246
Powered by Topicbox: https://topicbox.com

Reply via email to