avg-I commented on this pull request.
- if (!all && HDR_HAS_L2HDR(hdr) && - (hdr->b_l2hdr.b_daddr > taddr || + /* Ensure this header has finished being written. */ + ASSERT(!HDR_L2_WRITING(hdr)); + ASSERT(!HDR_L2_WRITE_HEAD(hdr)); + + if (!all && (hdr->b_l2hdr.b_daddr >= taddr || Yes, I did. `taddr` is the end of what we should evict (start + size). So, if a buffer starts at `taddr`, then it's beyond the area to be evicted. That one buffer, if any, does not make a lot of difference, but just for the sake of correctness. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/305#discussion_r121188505 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T88cf39f4aaf24fbf-Mc5125c8b60b6301bf4b2f8eb Powered by Topicbox: https://topicbox.com
