yuripv commented on this pull request.


> @@ -1733,7 +1736,7 @@ The failed device can be replaced using the following 
> command:
 .Ed
 .Pp
 Once the data has been resilvered, the spare is automatically removed and is
-made available should another device fails.
+made available for use should another device fails.

s/fails/fail/ too.

> @@ -77,7 +78,7 @@
 .Nm
 .Cm import
 .Op Fl D
-.Op Fl d Ar dir
+.Op Fl c Ar cachefile Ns | Ns Fl d Ar dir

I'm not sure if "-c cachefile" was left out on purpose here.  If that's not the 
case, please make sure to update this form of "import" subcommand in the 
DESCRIPTION as well.

> @@ -660,7 +661,7 @@ to the enabled state.
 See
 .Xr zpool-features 5
 for details on feature states.
-.It Sy listsnaps Ns = Ns Sy on Ns | Ns Sy off
+.It Sy listsnapshots Ns = Ns Sy on Ns | Ns Sy off

Could please include the https://www.illumos.org/issues/3796 in the commit 
message for this change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/415#pullrequestreview-46932102
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T82aee45b8910d354-M1ec303a2df2b75dac8c0058a
Powered by Topicbox: https://topicbox.com

Reply via email to