yuripv commented on this pull request.
> @@ -1367,7 +1370,7 @@ Upon reboot, the specified physical device reverts to
> its previous state.
.Ar pool Ar device Ns ...
.Xc
Brings the specified physical device online.
-This command is not applicable to spares.
+This command is not applicable to spares or cache devices.
I don't think this is correct:
```
antares:root:~# zpool create data c3t0d0 cache c3t1d0
antares:root:~# zpool offline data c3t1d0
antares:root:~# zpool status data
pool: data
state: ONLINE
status: One or more devices has been taken offline by the administrator.
Sufficient replicas exist for the pool to continue functioning in a
degraded state.
action: Online the device using 'zpool online' or replace the device with
'zpool replace'.
scan: none requested
config:
NAME STATE READ WRITE CKSUM
data ONLINE 0 0 0
c3t0d0 ONLINE 0 0 0
cache
c3t1d0 OFFLINE 0 0 0
errors: No known data errors
antares:root:~# zpool online data c3t1d0
antares:root:~# zpool status data
pool: data
state: ONLINE
scan: none requested
config:
NAME STATE READ WRITE CKSUM
data ONLINE 0 0 0
c3t0d0 ONLINE 0 0 0
cache
c3t1d0 ONLINE 0 0 0
errors: No known data errors
antares:root:~#
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/415#pullrequestreview-46939988
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T82aee45b8910d354-M6c8e345293ddb46962ac5284
Powered by Topicbox: https://topicbox.com
