yuripv requested changes on this pull request.
> @@ -34,7 +34,6 @@ */ #define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C)) #define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C)) -#define iscntrl(C) ((((C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f)) There's no need to turn this into function, simply remove the ```((C) >= 0)``` part - the compiler whines about checking if ```uchar``` is greater or equal to 0, and it's always true (and that check is annoying). P.S. it's sad to see yet another bunch of is* stuff added to kernel, they really need to be unified. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/418#pullrequestreview-48199198 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T3adedda59230e326-Mad91d357cd86c35ece48404a Powered by Topicbox: https://topicbox.com
