ikozhukhov commented on this pull request.
> @@ -34,7 +34,6 @@ */ #define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C)) #define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C)) -#define iscntrl(C) ((((C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f)) I have used kmdb libstand as reference for it. to me - will be more better to move functions per file and add it to shared place - and add to build where we need this function, but it is not for this update -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/418#discussion_r125778027 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T3adedda59230e326-M3d78f87ea153922ac93e595b Powered by Topicbox: https://topicbox.com
