ahrens commented on this pull request.
> @@ -54,6 +54,9 @@ struct uberblock {
/* highest SPA_VERSION supported by software that wrote this txg */
uint64_t ub_software_version;
+
+ /* reserved */
+ uint64_t padding[3];
This is OK, but I think it would be more clear to spell out the fields as they
will be in the final state, with comments explaining that they are not in use
yet:
```
/* These fields are reserved for features that are under development: */
uint64_t ub_mmp_magic;
uint64_t ub_mmp_delay;
uint64_t ub_checkpoint_txg;
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/425#pullrequestreview-49811543
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Td128c23c12b31635-M7d2f6bc188a106a7e723dec2
Powered by Topicbox: https://topicbox.com
