ofaaland commented on this pull request.


> @@ -54,6 +54,11 @@ struct uberblock {
 
        /* highest SPA_VERSION supported by software that wrote this txg */
        uint64_t        ub_software_version;
+
+       /* These fields are reserved for features that are under development: */
+       uint64_t        ub_mmp_magic;
+       uint64_t        ub_mmp_delay;
+       uint64_t        ub_checkpoint_txg;

Please add a third field for MMP, `uint64_t ub_mmp_sequence`, placed after 
`ub_mmp_delay`.  We will use it to provide sub-second resolution to allow 
faster detection of foreign imports.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/425#pullrequestreview-49838638
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/Td128c23c12b31635-Ma55260efa5cd8c2e9e25013b
Powered by Topicbox: https://topicbox.com

Reply via email to