Re: the dump issues, doing this:
```diff
diff --git a/usr/src/uts/common/fs/zfs/zvol.c b/usr/src/uts/common/fs/zfs/zvol.c
index c6a6338..080b2cd 100644
--- a/usr/src/uts/common/fs/zfs/zvol.c
+++ b/usr/src/uts/common/fs/zfs/zvol.c
@@ -2157,6 +2157,9 @@ zvol_dumpify(zvol_state_t *zv)
if (zv->zv_flags & ZVOL_RDONLY)
return (SET_ERROR(EROFS));
+ if (os->os_encrypted)
+ return (SET_ERROR(ENOTSUP));
+
if (zap_lookup(zv->zv_objset, ZVOL_ZAP_OBJ, ZVOL_DUMPSIZE,
8, 1, &dumpsize) != 0 || dumpsize != zv->zv_volsize) {
boolean_t resize = (dumpsize > 0);
```
Seems to be good enough to guard against dumpifying encrypted zvols, preventing
the panic. Attempting to use `dumpadm` on them after adding those two lines
exits like this:
```
# zfs get encryption zones
NAME PROPERTY VALUE SOURCE
zones encryption aes-256-ccm -
# zfs create -V 8G zones/dump2
# dumpadm -d /dev/zvol/dsk/zones/dump2
dumpadm: dumps not supported on /dev/zvol/dsk/zones/dump2
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/124#issuecomment-335917374
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Ta17fb0edb29e7895-M0aa778e801da638ebe38a67d
Powered by Topicbox: https://topicbox.com
