prakashsurya commented on this pull request.
> @@ -88,6 +89,9 @@ #include <sys/systeminfo.h> #define MAXISALEN 257 /* based on sysinfo(2) man page */ +static int mount_tq_nthr = 512; /* taskq threads for multi-threaded mounting */ I talked to Seb about this today, and it's like I was assuming. The number 512 here isn't necessarily special (we could change it), we just want a number large enough such that we can create enough threads to saturate the storage IOPs. Since each thread performing a mount will generally be IO bound, we want to have enough threads mounting concurrently, so that we more effectively utilize the storage IOPs. As far as CPU caps and zone considerations, I _think_ 512 should be fine. The performance consideration here is to make sure we issue enough IO, so we still want to have multiple threads issues mounts concurrently, even if we can only have a single thread running at a time. i.e. we want to be able to issue another mount, when the previous thread/mount blocks on IO. With that said, I'm not familiar with the CPU caps available, so perhaps I'm overlooking something. Let me know if you'd like some more information, and/or if you still have concerns here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/536#discussion_r167648019 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T22334a01fda83bfd-Ma5151a88b3323f09b4774cf3 Powered by Topicbox: https://topicbox.com