avg-I commented on this pull request.


> @@ -4924,12 +4924,18 @@ zdb_embedded_block(char *thing)
                exit(1);
        }
        ASSERT3U(BPE_GET_LSIZE(&bp), <=, SPA_MAXBLOCKSIZE);
+       buf = malloc(SPA_MAXBLOCKSIZE);
+       if (buf == NULL) {
+               (void) printf("out of memory\n");

Please use `fprintf(stderr, ...)`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/635#pullrequestreview-117953942
------------------------------------------
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/T878c8282c1bf80d5-M28a175683d042aeae72278e8
Delivery options: https://openzfs.topicbox.com/groups

Reply via email to