ahrens commented on this pull request.
> @@ -4924,12 +4924,18 @@ zdb_embedded_block(char *thing)
exit(1);
}
ASSERT3U(BPE_GET_LSIZE(&bp), <=, SPA_MAXBLOCKSIZE);
+ buf = malloc(SPA_MAXBLOCKSIZE);
+ if (buf == NULL) {
+ (void) printf("out of memory\n");
I agree that going to stderr would be better. Feel free to fix both uses in
this func while you're here, or to leave it for another PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/635#discussion_r186475548
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T878c8282c1bf80d5-Mdb4f83cebdf1bddd7ad168d7
Delivery options: https://openzfs.topicbox.com/groups
