yuripv commented on this pull request.
> @@ -176,6 +176,8 @@ export KEEP="^$(echo $KEEP | sed 's/ /$|^/g')\$"
num_disks=$(echo $DISKS | awk '{print NF}')
[[ $num_disks -lt 3 ]] && fail "Not enough disks to run ZFS Test Suite"
+sudo -k coreadm -e process
This effectively changes coreadm settings and doesn't restore them, which makes
this change a bit pointless -- we could just mention the needed settings in
README instead.
> @@ -15,6 +15,6 @@
.PARALLEL: $(SUBDIRS)
-SUBDIRS:sh = find ./* -maxdepth 0 -type d
+SUBDIRS:sh = ls */Makefile 2>/dev/null | sed 's/\/Makefile//g'
This doesn't seem to be related?
> @@ -60,4 +60,4 @@ $(TARGETDIR)/%: %
$(INS.file)
.PARALLEL: $(SUBDIRS)
-SUBDIRS:sh = find ./* -maxdepth 0 -type d
+SUBDIRS:sh = ls */Makefile 2>/dev/null | sed 's/\/Makefile//g'
This doesn't seem to be related?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/571#pullrequestreview-118491273
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/Ta01e586f3e29f982-M9b244df88e0a315f395029c8
Delivery options: https://openzfs.topicbox.com/groups
