jwk404 commented on this pull request.
> @@ -15,6 +15,6 @@
.PARALLEL: $(SUBDIRS)
-SUBDIRS:sh = find ./* -maxdepth 0 -type d
+SUBDIRS:sh = ls */Makefile 2>/dev/null | sed 's/\/Makefile//g'
This is part of a Delphix fix that solved 7710 a little differently. It
shouldn't be upstreamed.
> @@ -60,4 +60,4 @@ $(TARGETDIR)/%: %
$(INS.file)
.PARALLEL: $(SUBDIRS)
-SUBDIRS:sh = find ./* -maxdepth 0 -type d
+SUBDIRS:sh = ls */Makefile 2>/dev/null | sed 's/\/Makefile//g'
Same.
> @@ -176,6 +176,8 @@ export KEEP="^$(echo $KEEP | sed 's/ /$|^/g')\$"
num_disks=$(echo $DISKS | awk '{print NF}')
[[ $num_disks -lt 3 ]] && fail "Not enough disks to run ZFS Test Suite"
+sudo -k coreadm -e process
The `-i core` from the description was changed during review - the description
is wrong.
I think it's better to have this command in the wrapper script than have a
comment in the README that folks may or may not read. I also feel that it's
appropriate to change system wide settings on a test system.
That said, if this is a blocker for you, let us know; it's easy enough to
restore the setting. Alternatively, we could simply abandon this PR - I don't
expect that coreadm settings need to be changed on other platforms.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/571#discussion_r188060301
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/Ta01e586f3e29f982-Md95b10871832487654481ebb
Delivery options: https://openzfs.topicbox.com/groups
