The issue is that the error handling in zfs diff was not updated to reflect that files on the delete queue no longer trigger a non-zero return value. As a result, delete-queue files in the from snapshot are no longer ignored by zfs diff, which results in misleading and incorrect behavior. The fix is to reinstate the error handling logic and tweak it to work appropriately with the new behavior.
Reviewed-by: Matthew Ahrens mahr...@delphix.com Reviewed-by: George Wilson gwil...@delphix.com External Issue: DLPX-58635 You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/644 -- Commit Summary -- * DLPX-58635 zfs diff handles files on delete queue in fromsnap poorly -- File Changes -- M usr/src/lib/libzfs/common/libzfs_diff.c (14) -- Patch Links -- https://github.com/openzfs/openzfs/pull/644.patch https://github.com/openzfs/openzfs/pull/644.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/644 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T81f17cd2d743f0dd-M1002a533dc2afbcf3afdfbd4 Delivery options: https://openzfs.topicbox.com/groups
