tonynguien commented on this pull request. Overall - The refactoring makes it easier to read. Thanks. I have two comments.
In general, test scripts do recreate_perf_pool() and populate_perf_filesystems() then call do_fio_run() which may recreate the pool. Can we not create the pool once and import/export to clear cache or populate_perf_filesystems() as needed? This will save time as we only need to populate data once for majority of our current tests. write_zil.sh being the exception libtest.shlib - Both create_dataset() and destroy_dataset() calls datasetexists() and check for non-zero length $dataset variable. Given that create_dataset() is the only caller to destroy_dataset(), we can omit the checks in destroy_dataset() unless we think there will be other callers/consumers in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/634#pullrequestreview-124671607 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T0307887c7165c81e-Mbc2f275b25115b0391da77cb Delivery options: https://openzfs.topicbox.com/groups
