Hi,

FYI, I think you may be interested in one of our (FreeBSD) recent change
to lzjb decompression.

FreeBSD r256132:

Improve lzjb decompress performance by reorganizing the code
to tighten the copy loop.

Received: from [64.62.153.212] (helo=anubis.delphij.net)
        by node002.open-zfs.net
        with esmtp (HybridCluster distributed mail proxy)
        (envelope-from <[email protected]>); Fri, 11 Oct 2013 02:39:10 -0000
Submitted by:   Denis Ahrens <denis h3q com>

Should I file a ticket for this for tracking?

Cheers,
-- 
Xin LI <[email protected]>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lzjb.c
===================================================================
--- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lzjb.c       (revision 
256131)
+++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lzjb.c       (revision 
256132)
@@ -117,7 +117,9 @@
                        src += 2;
                        if ((cpy = dst - offset) < (uchar_t *)d_start)
                                return (-1);
-                       while (--mlen >= 0 && dst < d_end)
+                       if (mlen > (d_end - dst))
+                               mlen = d_end - dst;
+                       while (--mlen >= 0)
                                *dst++ = *cpy++;
                } else {
                        *dst++ = *src++;
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to