Thanks for letting us know about this. I have a few comments: 1. We could eliminate a branch entirely by doing this:
mlen = MIN(d_end - dst, mlen);
while (--mlen >= 0)
*dst++ = *cpy++
2. This optimization could become a generic optimization pass in the
system compiler. If anyone wants to be helpful, I would suggest sending
this patch to the developers of both LLVM and GCC.
3. Have any benchmarks been done to quantify the performance
improvement? That should not be required to merge this, but if any
benchmarks have been done, I would like to see them for my own curiosity.
On 10/10/2013 10:39 PM, Xin Li wrote:
> Hi,
>
> FYI, I think you may be interested in one of our (FreeBSD) recent change
> to lzjb decompression.
>
> FreeBSD r256132:
>
> Improve lzjb decompress performance by reorganizing the code
> to tighten the copy loop.
>
> Received: from [64.62.153.212] (helo=anubis.delphij.net)
> by node002.open-zfs.net
> with esmtp (HybridCluster distributed mail proxy)
> (envelope-from <[email protected]>); Fri, 11 Oct 2013 02:39:10 -0000
> Submitted by: Denis Ahrens <denis h3q com>
>
> Should I file a ticket for this for tracking?
>
> Cheers,
>
>
>
> _______________________________________________
> developer mailing list
> [email protected]
> http://lists.open-zfs.org/mailman/listinfo/developer
>
signature.asc
Description: OpenPGP digital signature
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
