On Sat, Oct 12, 2013 at 12:48:15AM -0400, Richard Yao wrote:
> Dear Everyone,
> 
> I did a cursory review of changes to the ZFSOnLinux repository made
> during the past 12 months and identified a number of commits that
> probably should be sent to Illumos.
> 
> I have attached a preliminary list. I did a really quick review, so I
> expect that there are a few false positives included and probably a few
> false negatives excluded.
> 
Received: from [91.121.88.72] (helo=mail.dawidek.net)
        by node002.open-zfs.net
        with esmtp (HybridCluster distributed mail proxy)
        (envelope-from <[email protected]>); Sun, 13 Oct 2013 17:36:19 -0000
> I can do a more thorough review to produce a comprehensive list, but the
> important thing is to work out the process to get the improvements made
> in ZFSOnLinux either merged back into Illumos or rejected with some kind
> of explanation why so that appropriate changes can be made in ZFSOnLinux
> to reduce code differences.
> 
> Does anyone have any thoughts?
> 
> Yours truly,
> Richard Yao

> commit 86dd0fd9222b6103c6533036c47b908ece944460
> Author: Brian Behlendorf <[email protected]>
> Date:   Sun Aug 19 17:17:02 2012 -0700
> 
>     Pre-allocate vdev I/O buffers
>     
>     The vdev queue layer may require a small number of buffers
>     when attempting to create aggregate I/O requests.  Rather than
>     attempting to allocate them from the global zio buffers, which
>     is slow under memory pressure, it makes sense to pre-allocate
>     them because...
[...]

I cannot read the rest of the attachement, but I have a fix in this area
as well, because of a report that we can deadlock here while waiting for
memory.

My change doesn't do aggregation if there is no memory available.

        
http://people.freebsd.org/~pjd/patches/zfs_aggregation_deadlock_fix.patch

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://mobter.com

Attachment: pgp8knEmXyiBh.pgp
Description: PGP signature

_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to