----- Original Message -----
From: "Matthew Ahrens" <[email protected]>
To: "illumos-zfs" <[email protected]>; "Steven Hartland"
<[email protected]>
Cc: "developer" <[email protected]>
Sent: Monday, September 29, 2014 9:52 PM
Subject: Re: [zfs] Possible miss-merge of 4369 implement zfs bookmarks
On Mon, Sep 29, 2014 at 12:49 PM, Steven Hartland via illumos-zfs <
[email protected]> wrote:
I've just spotted what looks like a possible miss-merge of:
4369 implement zfs bookmarks
This is not a mis-merge, at least not from DelphixOS, where the patch is
the same.
It seems we've lost the snap must be in the specified pool
check as well as the check for error on unmount which was
specifically added by:
3744 zfs shouldn't ignore errors unmounting snapshots
I believe that the semantics should be the same as if that code had been
left in place. dsl_destroy_snapshot_check() will fail if a snapshot is in
a different pool. It will also fail if a snapshot is mounted.
Do you have a test case which shows that the current behavior is
undesirable?
What actually drew my attention was the loss of the FreeBSD:-
(void) zvol_remove_minors(name);
Which used to run after zfs_unmount_snap(name); in zfs_ioc_destroy_snaps
but ended up in zfs_ioc_destroy_bookmarks.
Tracing back through the history lead to the merge of this change, which
looked a little odd given the previous history explicity added these check, I
assumed for a good reason.
This may be reason enough to keep the checks in FreeBSD as without
it we could destroy the minors even though the snapshot unmount failed
which would be indesireable.
Regards
Steve
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
