On Mon, Sep 29, 2014 at 3:45 PM, Steven Hartland <[email protected]> wrote:
> ----- Original Message ----- From: "Steven Hartland" > > I believe that the semantics should be the same as if that code had been >>> left in place. dsl_destroy_snapshot_check() will fail if a snapshot is >>> in >>> a different pool. It will also fail if a snapshot is mounted. >>> >> > Thinking about it, while the command will still fail surely the original > error (why the unmount failed) will be lost and hence its still better to > have this check and return early so the user gets the correct error? > If unmount gives a more specific error, which is properly printed by userland, then I agree. --matt
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
