> On May 14, 2015, 3:11 p.m., Bayard Bell wrote: > > usr/src/uts/common/fs/zfs/dnode.c, line 1654 > > <https://reviews.csiden.org/r/218/diff/1/?file=15078#file15078line1654> > > > > However suggests a contrast that's not apparent, and the antecedent for > > "them" is not clear, either. > > > > Need a clearer opening line, and, as the need for this was previously > > non-obvious, commenting this clearly seems important to maintainability.
The contrast is that the normal purpose of dirtying a block is to indicate that it needs to be written out, but in this case the block will not be written. The part after the "however:" explains why we dirty it in spite of this. "The interior blocks ... they will not actually be written. However, dirtying them" -> "they" and "them" both refer to "The interior blocks" that this code dirties. I've updated the comment to make this more obvious. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/218/#review706 ----------------------------------------------------------- On May 5, 2015, 9:10 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/218/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 9:10 p.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5911 > https://www.illumos.org/projects/illumos-gate//issues/5911 > > > Repository: illumos-gate > > > Description > ------- > > 5911 ZFS "hangs" while deleting file > > Original author: Matthew Ahrens > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/sys/dbuf.h > c542c8aec875a20374d80d2f61bed856515c9c88 > usr/src/uts/common/fs/zfs/dnode_sync.c > bb18718bed73974556f03abec01e3bf31cb06a9d > usr/src/uts/common/fs/zfs/dnode.c 12d8db76faed60cc9ddf80877b5f91090214da44 > usr/src/uts/common/fs/zfs/dmu_tx.c 56ce2f0c279f8ac445ae4627713ea121dc378e0b > usr/src/uts/common/fs/zfs/dbuf.c 465dfd08b2302493b38e561432bf320c05d1f9f6 > > Diff: https://reviews.csiden.org/r/218/diff/ > > > Testing > ------- > > ztest > zfs test suite > working on manual testing > > http://jenkins.delphix.com/job/zfs-precommit/2227/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
