----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/218/#review708 -----------------------------------------------------------
usr/src/uts/common/fs/zfs/dnode.c (line 1680) <https://reviews.csiden.org/r/218/#comment554> Nit - better to have "shift" as uint_t or even uint8_t ? usr/src/uts/common/fs/zfs/dnode.c (line 1682) <https://reviews.csiden.org/r/218/#comment555> i <= last : Since dnode_dirty_l1 for the "last" was already done earlier above, maybe that could be avoided ? BTW, we were chasing this issue too and looking into the same code paths. It was affecting group delete (rm -f) of huge files (like 32GB files) running into ~20mins range. I tested this change and happy to report that this change works great, it has reduced the time taken to group remove such large files into ~30 seconds or so. - Prashanth Sreenivasa On May 14, 2015, 6:05 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/218/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 6:05 p.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5911 > https://www.illumos.org/projects/illumos-gate//issues/5911 > > > Repository: illumos-gate > > > Description > ------- > > 5911 ZFS "hangs" while deleting file > > Original author: Matthew Ahrens > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/sys/dbuf.h > c542c8aec875a20374d80d2f61bed856515c9c88 > usr/src/uts/common/fs/zfs/dnode_sync.c > bb18718bed73974556f03abec01e3bf31cb06a9d > usr/src/uts/common/fs/zfs/dnode.c 12d8db76faed60cc9ddf80877b5f91090214da44 > usr/src/uts/common/fs/zfs/dmu_tx.c 56ce2f0c279f8ac445ae4627713ea121dc378e0b > usr/src/uts/common/fs/zfs/dbuf.c 465dfd08b2302493b38e561432bf320c05d1f9f6 > > Diff: https://reviews.csiden.org/r/218/diff/ > > > Testing > ------- > > ztest > zfs test suite > working on manual testing > > http://jenkins.delphix.com/job/zfs-precommit/2227/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
