On Thu, Jan 14, 2016 at 7:24 AM, Dan McDonald <dan...@omniti.com> wrote:
> > > On Jan 13, 2016, at 11:26 PM, Matthew Ahrens <mahr...@delphix.com> > wrote: > > > > Changes look good. Lots of improvement per line of code changed :-) > > I know, right?! > > > It would be great if we also had a test for receiving a full stream > that's over refquota (which should work due to the "delay_props" changes > that were made recently). > > Something like this? > > zfs create rpool/foo > zfs set refquota=10M rpool/foo > yes > /rpool/foo/fill-er-up > zfs snapshot rpool/foo@1 > zfs send rpool/foo@1 | zfs recv rpool/bar > > If that's what you're thinking, I'll run the above on both > before-and-after to make sure it works and create zfs_receive_013_pos... > Yes, thank you! > > > I would just ask that you restructure the comment to be less wordy and > less of an appeal to authority. > > I was hoping someone would mention this. > > > Here's my attempt at rewriting it: > > Took your change pretty much as-written: > > /* > * The clone can't be too much over the head's refquota. > * > * To ensure that the entire refquota can be used, we allow one > * transaction to exceed the the refquota. Therefore, this check > * needs to also allow for the space referenced to be more than the > * refquota. The maximum amount of space that one transaction can > use > * on disk is DMU_MAX_ACCESS * spa_asize_inflation. Allowing this > * overage ensures that we are able to receive a filesystem that > * exceeds the refquota on the source system. > * > * So that overage is the refquota_slack we use below. > */ > if (origin_head->ds_quota != 0 && > dsl_dataset_phys(clone)->ds_referenced_bytes > > origin_head->ds_quota + refquota_slack) > > Meanwhile, I have some potentially problematic test results. John K. and > I are discussing them now. I'll re-ping this thread, or start a new one > with an appropriate illumos bug id, once I sort that all out and likely add > zfs_receive_013_pos as well. > > Thanks! > Dan > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
