Hello View the length of the document this looks I don't feel this is really a "hacking" guide. But it is very good documentation , hacking bible?
It puts quite some weight into coding standards. I like the idea of "real and sub commitors" But think that if we want to go that way we need to enforce this with real access rights to the cvs (here speaks a person who's greatest hack was the creation of the speeltuin module) > * @param state Description of parameter > * @return expected return values > */ > private static final int foo(int arg1, int arg2) bad example :) It's always fun to show how not to program. maybe a link to http://mindprod.com/unmain.html is on it's place? > /* Generally use the 8-space rule */ 4 spaces? > arg1 = 10 + some_func (arg1, arg2); /* Use space around > operators */ Never in mmbase code > The email message should start off with a log message, as described in > "Writing > log messages" above. The patch itself should be in unified diff format > (e.g., with "cvs diff"). Send the patch as an attachment, with a mime-type of > text/x-diff, text/x-patch, or text/plain. (Most people's mailreaders can > display those inline, and having the patch as an attachment allows them to > extract the patch from the message conveniently.) I don't see the point in using patches. the easiest way of testing if something works is just to replace the file/files sent. People can then view the diffs in there favourite editors. asking for patches makes the process to difficult. perhaps in the bug tracker we need to make it possible to add patches. that fix the problem. > It is normal for patches to undergo several > rounds of feedback and change before The feedback is usually about the documentation or chosen approach not about the actual code > The "Patch Manager" Role: > ------------------------- with commitors / sub commitors the role of the patch manager is a bit weird but it's good to have somebody watching the process _______________________________________________ Developers mailing list [email protected] http://lists.mmbase.org/mailman/listinfo/developers
