marcel maatkamp wrote:
I post this because I dont know if the original maintainer didn't use this feature with a reason.
No, I didn't us e acache because I didn't expect there to be peformance reasons and, as Nico wrote, because I want the method to do what it says: check if the table exists.
That said, it doesn't mean that a cache isn't useful. However I think in that case it should be called (with appropriate paramters as provided by Nico) when the storage layer is initialized. Exists then only has to check the cache. The cache need to be renewed or refreshed when builders are added or removed. As to verify(): it may be useful to add a property which allows you to skip verification, if you expect data to be consistent and the verification takes too long to your liking. Perhaps as an option in the mmbaseroot module.
I am fine if Marcel adds these changes to MMBase 1.8, courtesy Optimization project.
Oh, note that officially, in the StorageManager, you get the MMBase "basename" by calling: factory.getStorageIdentifier(this)
-- Pierre van Rooden Mediapark, C 107 tel. +31 (0)35 6772815 "Anything worth doing is worth overdoing." _______________________________________________ Developers mailing list [email protected] http://lists.mmbase.org/mailman/listinfo/developers
