Nico Klasens wrote: > Hello Ernst > > It is not a problem of the ApplicationInstaller. It always happens at > the moment when a typerel node is inserted. > > This happens, because you reimplemented the NodeEvent. It first had the > full MMObjectNode as a member, but now not anymore. This warning is just > a check like the comment says in MMObjectBuilder > > // it seems that the something put the node in the cache already. > // This is usually because the ChangeManager indirectly called 'getNode' > // This should in the new event-mechanism not be needed, because the > // NodeEvent contains the node. > > Now the NodeEvent does not have the Node anymore. Typerel does a > getNode() in the notify method which triggers this. I didn't fix it, > because I thought you were still working on it :) > I think the warning can just be removed, but I am not 100% sure. >
Yes. I added that code because I noticed that sometimes something was put in the node-cache wich was already in there. I'm not sure how bad that is, but it seemed undesirable at the very least, so I added this warning, so that you can see it happening at least. Indeed it did not happen before, undoubtly the change of NodeEvent triggered it again. I'm not confident that it cannot harm, so I did not remove it yet. It seems dangerous a bit to have 2 MMObjectNode instances around representing the same node. What for example if changes in one of the instances are made? They are not reflected in the other. I'd rather avoid it. Though indeed I'm not absolutely sure that it will effectively cause problems. Perhaps not. Michiel -- Michiel Meeuwissen mihxil' Peperbus 111 MediaPark H'sum [] () +31 (0)35 6772979 nl_NL eo_XX en_US _______________________________________________ Developers mailing list [email protected] http://lists.mmbase.org/mailman/listinfo/developers
