Nico Klasens wrote:
Ernst Bunders wrote:
Nico Klasens wrote:
Hello Ernst
It is not a problem of the ApplicationInstaller. It always happens at
the moment when a typerel node is inserted.
This happens, because you reimplemented the NodeEvent. It first had
the full MMObjectNode as a member, but now not anymore. This warning
is just a check like the comment says in MMObjectBuilder
// it seems that the something put the node in the cache already.
// This is usually because the ChangeManager indirectly called 'getNode'
// This should in the new event-mechanism not be needed, because the
// NodeEvent contains the node.
Now the NodeEvent does not have the Node anymore. Typerel does a
getNode() in the notify method which triggers this. I didn't fix it,
because I thought you were still working on it :)
I think the warning can just be removed, but I am not 100% sure.
hi Nico
I think the NodeEvent is as it should be now. I wonder if the message
should be removed. After all, if it happens, something is (or should
be) wrong. So i think it is best to find another solution, to avoid
it's occurence in this situation.
Hi Ernst,
It is a programmer warning which does not apply anymore.
But there is something still ugly. Typerel.notify has the line
log.service("Added to typerelcache: " +
addCacheEntry(getNode(event.getNodeNumber()), true));
WHy is the addCacheEntry inside the log statement?
I guess that is 'compact programming'. addCacheEntry() returns the
created TypeRelSet if it was created. Bit odd, but not a problem i guess.
Ernst
Nico
_______________________________________________
Developers mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/developers
_______________________________________________
Developers mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/developers
