Michiel Meeuwissen wrote:
> Nico Klasens wrote:
> > Pierre van Rooden wrote:
> > >Nico Klasens wrote:
> > >
> > >>MMBaseTest and BridgeTest - Both fail on the same mmb.isShutDown()
> > >
> > >
> > >That is a typo - it should be mmb.isShutdown(), with a lowercase 'd'.
> > >You're welcome to change it, otherwise I can solve this tomorrow.
> > >
> >
> > So I guessed right that mmb is an MMBase object. Fixed the errors.
> >
> > Now what about ProcessorModule
> > public final Vector getNodeList(Object context, String command, Map
> > params) {
> >
> > Should this be final?
>
> Probably not then. I figured that since getNodeList seems to be basicily a
> wrapper
> around getList, that it can as well be final, which would enforce that
> both these methods represent the same functionality, and confirm this
> 'conjecture'. So, if this conjecture is promoted to a postulate, it can
> remain final, and CommunityPrc must have extended getList. If the
> conjecture is false, then it must not be final. I seem to have forgotten
> to check to compile CommunityPrc. It not compiling perhaps proves that
> the assumption was not safe then.... Though assuming that CommunityPrc
> is silly coded does not seem odd either.
I took a little look at CommunityPrc. It is oddly coded indeed, because
it extends both getList and getNodelist, but it seems with the same
commands. One of the commands 'TREE' is mentioned in the javadoc of
getNodeList, but not implemented, super is called for it, which will
then call TREE in getList (so that command follows by 'conjecture').
So, perhaps it is enough to simply _remove_ getNodeList from
CommunityPrc altogether, in which case my daring action of making this method
final
will result in a considerable clean-up of CommunityPrc....
I have no time now to explore if there are any substantial, meaningful
differences
in the getList and getNodeList versions of CommunityPrc. Perhaps
somebody knows it by heart?
Michiel
--
Michiel Meeuwissen mihxil'
Peperbus 111 MediaPark H'sum [] ()
+31 (0)35 6772979 nl_NL eo_XX en_US
_______________________________________________
Developers mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/developers
