Nico Klasens <[EMAIL PROTECTED]> wrote:
> > > When will the freeze start (on which things does it depend) ?
> > 
> > I suggest to freeze asap.
> > Which means I (or RvM) have to make a quick Hack proposal for 'full
> > backup' in Apps1 before the 24th...
> 
> Maybe it is a good moment when the freeze starts and before the branch
> is mode that we style-format the code to the coding standards we have.
> The style-format won't change the functional behaviour of the code, but
> it will improve the readability of the code. 

I'd like to see a few additions to the code-conventions.

For example I think the standard java code convention is limiting the code
to 80 collumns which I think is silly in these moderns times. 180 would be more 
realistic.

Furthermore more I don't like to see relatively unimportant log messages bloat up
to over 10 lines like this:
                                log.error(      
                                        "converter from location "
                                                + converterPath
                                                + ", gave strange result: "
                                                + outputStream.toString()
                                                + "conv.root='"
                                                + converterRoot
                                                + "' conv.command='"
                                                + converterCommand
                                                + "'");
I'd rather see conventionalized that it becomes something like this:

 log.error("converter from location " + converterPath + ", gave strange result: " + 
outputStream.toString()
            + "conv.root='" + converterRoot + "'conv.command='" + converterCommand + 
"'");



Michiel


-- 
Michiel Meeuwissen 
Mediapark C101 Hilversum  
+31 (0)35 6772979
nl_NL eo_XX en_US
mihxil'
 [] ()

Reply via email to