Let me try to anwer your questions and give (as others have hinted to) the 2 steps way (now
and in 1.8) in the hope to stop this discussion since well i feel ive started something i can't
get out of anymore :)
btw: i do pierre's efforts to 'recap' is a good idea and i thank him for that and others who
have tried to solve the problem.
On Jan 14, 2004, at 4:34 PM, Pierre van Rooden wrote:
CALL FOR: Email changes: drop email classes and Interface from the core
Called by: Daniel Ockeloen Total tally on this call : +4
YEA (4) : Pierre van Rooden, Rob van Maris, Michiel Meeuwissen, Nico Klasens
ABSTAIN (0) :
NAY (0) :
VETO (0) :
No votes, assumed abstained (10): Eduard Witteveen, Jaco de Groot, Marcel Maatkamp, David van Zeventer, Johannes Verelst, Daniel Ockeloen, Rob Vermeulen, Kees Jongenburger, Rico Jansen, Vincent van der Locht, Gerard van Enk, Mark Huijser
This call is ON HOLD, after a petition by Kees Jongenburger, requesting for more information on this call.
The caller of the vote is requested to provide information regarding the changes (what they entail and what the consequences are), before voting proceeds.
The following questions were asked:
1) What [in the core email builder] was broken?
Apart from having alot of classes nobody (including me) really know how they work there is one clear problem that results in errors. The error only happens
if you send multiple mail's in a loop (for example you look using mm:related all the users in a group). The problem is/was that the node gets deleted by the mailer before the tag (mm:node i think) finished resulting i a error. This doesn't allways happen (timing) but mail 1000 people this way and changes are it will stop at 344. Also allmost nobody uses the builder for what it was created for (sending mail to groups, related groups, times mails etc etc) most only did 'mail 1 person' at a time.
Since we wanted to fix it but nobody dared to touch it we did a hack vote about 6 months ago resulting in a new email application (that upto last week had its last version in the 'speeltuin'.
2) What 2 interfaces can you use?
If its upto me now it seems best to leave the 2 SendMail versions in the core, the new email application provides 3e implementation of the
interface but also extra methods for mine (not usable from that interface).
3) If sendmailInterface is moved how will the core classes that use sendmail compile ?
More research (and lots of comments) resulted in the view that it means to much changes now. But that was indeed
the problem of all the classes we found most should be applications by themselfs in the future or should not be in
mmbase at all.
a) (returning null + log message) is not acceptable. we need to remove it or return something good
b) as far as i known the interface of SendMail was not changed why do we need changes to sendmail.xml?
changes are needed to select the new mailer (if you want to use the new email app) instead of the one in org.mmbase.module (most use JSendMail now)
4) what wil happen to current code in the core that will brake?
now nothing, keeps working (or is just as broken as before) if we did more it would have to be fixed as well as far as i could see only the
mailing vwm would have been a real problem the rest should be a application by itself or not in cvs at all.
org/mmbase/module/builders/Email.java org/mmbase/module/builders/Vwms.java org/mmbase/module/MMUsers.java (what even that is) org/mmbase/servlet/SimpleFormToMailServlet.java org/mmbase/module/LinkChecker.java
Note that questions above are edited according to insight and that additional questions may be asked.
If questions have been answered to satisfaction voting will resume.
Note that you may still vote (or cahnge your vote), and votes are still counted, but the call will not be closed until this issue is resolved.
So what happens now if i (the caller) as a result from comments and the VETO, compromise like this ?
Again my view now :
Oops too many problems with code someone has to cleanup first
Keep the Interfaces and implemations as they are now until 1.8
Add a new implemation as part of the new email applications
Make sure its fixed for 1.8 so it can be removed.
Daniel.
