Michiel Meeuwissen wrote:

Andr? van Toly <[EMAIL PROTECTED]> wrote:


Hi,

At 12:06 +0100 16-02-2004, ernst bunders wrote:


hi
i discovered som new taglib behabour that i suspect to be a bug. the <mm:fieldinfo type="input"/> tag now generates a formfield with a wrong 'name' attribute value. the fieldname is preceded by an underscore.
Ernst


I think that when using <mm:fieldinfo type="input" /> together with <mm:fieldinfo type="useinput" /> useinput will also aspect an underscore. In that case there's no problem. Unexpected behavior will occur when you're using 'input' without using 'useinput' which you normally wouldn't but still...



Yes, that's right. You normally should not process the result of 'input' with something else then 'useinput'. And if you do so, I'd like to know why, because that probably means that something is not ok, or readily useable.

I in the mean time compared the 1.7 code with the 1.6 code, and indeed now
always a _ is added. Probably to reduce the chance on accidental clashes with
other vars.

So, I don't know what to do, I could change it back, but I think the change
was good in principle. So It would be done to serve hackery on 1.6 because
as said, it is not defined what 'input' should do, only that 'useinput' can
process it. I'm not unwilling to change it back, but not without
clarifications why 'useinput' indeed was not feasible there.


Michiel




well, that's the problem. I'm not using the mm:useinput. In preveous taglib version this was not a problem, but now it is. The problem uccured in the kbase (that i am now in the proces of putting online). It dous most things in java and only some in 'taglib'. Anyhow i fixed it by adding an underscore to a parameter name if the request object returns null unexpectedly.
I have allways seen the fieldlist and fieldinfo as a conveniant way for quickly making a form for an object. Of course if you use only taglib for your logic you will allways use the 'useinput' tag to process the input. This is not allways feasable though.
It seems logical to me that the name of the formfield equals the fieldname, and i would allso consider this as a backwards compatability issue. I'm shure i have used the tag like this before. So, i quess that you should change it back, but decide for yourselfe.


I don't use the bugtracker becouse i don't know the conventions. I actually thougt that it is used by committers. If not so, i will use it in the future. are there any regulations that i should be aware of?

Ernst



Reply via email to