+1, that is good news. Am 26.01.2013 um 01:06 schrieb "Knoll Lars <[email protected]>" <[email protected]>:
> Hi Lazlo, > > sorry for the late answer. > > I went through the module now, and it looks like a good and solid piece of work. Thanks to everybody who contributed :) > > From an API perspective it looks pretty good. I'm not an expert on serial ports, but from what I recall from the time I dealt a little with them (must be 10 years ago or so…) it looks pretty complete as well. S o with the changes proposed on the mailing list I believe the API is good to go :) > > Docs are also looking good IMO, so I'm happy to graduate it to an add-on for 5.1. > > There are a few remaining things I'd like to see happen before that though: > > * Could you please fix the copyright headers to out standard form (simply check a header from qtbase)? > * Could you give the module the same structure as the other Qt modules, esp. with regards to where the source for the docs live? Please check http://qt-project.org/wiki/Creating-a-new-module-or-tool-for-Qt and make sure the module follows the guidelines. > * I'm fine calling the module just QtSerialPort instead of QtAddonSerialPort to simplify naming. I doubt we'll get conflicts in the future because of that. > * The double namespace is a requirement we have removed, a simple "namespace QtSerialPort" is enough. > > And a question: There's no auto tests. I know that testing serial ports can't really be done in an automated fashion, but is there anything we can do to cover the module? > > Cheers, > Lars > > > On Jan 10, 2013, at 8:47 PM, Laszlo Papp <[email protected]> wrote: > >> API headers: >> >> http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialport.h >> http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialportinfo.h >> >> Docs: >> >> http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialport.cpp >> http://qt.gitorious.org/qtplayground/qtserialport/blobs/master/src/serialport/serialportinfo.cpp >> >> Examples: >> >> http://qt.gitorious.org/qtplayground/qtserialport/trees/master/examples >> >> On Wed, Jan 9, 2013 at 10:37 PM, Thiago Macieira <[email protected]> wrote: >>> On quarta-feira, 9 de janeiro de 2013 21.18.40, Laszlo Papp wrote: >>> > Another try: can we reiterate this question for 5.1? >>> >>> Can you post the API headers and a link to the docs and examples, so we can do >>> an API review? >>> -- >>> Thiago Macieira - thiago.macieira (AT) intel.com >>> Software Architect - Intel Open Source Technology Center >>> >>> _______________________________________________ >>> Development mailing list >>> [email protected] >>> http://lists.qt-project.org/mailman/listinfo/development >> >> _______________________________________________ >> Development mailing list >> [email protected] >> http://lists.qt-project.org/mailman/listinfo/development > > <Part.002> __________________________________________ The content of this e-mail is confidential and restricted for the use of the intended recipient only. If you are not the intended recipient please inform the sender immediately and delete this e-mail and any attachments. We cannot accept liability for any damage incurred as a result of software viruses and advise that you carry out your own virus checks before opening any attachment. Der Inhalt dieses E-Mails ist vertraulich und für die alleinige Verwendung durch den beabsichtigten Empfänger bestimmt. Falls Sie nicht der beabsichtigte Empfänger sind, bitten wir Sie den Absender umgehend zu informieren und dieses E-Mail samt angeschlossenen Dateien zu löschen. Wir können keine Haftung für allfällige Schäden übernehmen, die aufgrund von Software-Viren entstehen, und empfehlen Ihnen, selbst Virenprüfungen durchzuführen, bevor Sie eine Anlage öffnen.
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
