Hi, On 01/29/2013 12:57 PM, Jason McDonald wrote: > On Tue, Jan 29, 2013 at 12:52 AM, Sergio Ahumada > <[email protected]> wrote: >> On 01/28/2013 03:52 PM, Peter Kümmel wrote: >>> Seems currently everybody could merge to staging. >>> I as non-approver have a merge button in gerrit. >>> >>> Or is this only a new feature to see if the >>> request passes all tests? >>> >>> Peter >> >> see >> http://lists.qt-project.org/pipermail/development/2013-January/009467.html > > I think there is a problem here. The announcement in the link seems > to indicate that the intention was only to present non-approvers with > a "Merge patchset x to Staging" button once the commit has at least > one +2. I'm now seeing the merge button on commits without any +2's, > and even on commits where the only score is a -1. For example, see > https://codereview.qt-project.org/#change,43299. > > IMO, we don't want over-eager contributors pressing that button and > staging a change before an approver has approved it.
I sort of remember that if you try to stage/submit a change that doesnt have at least one +2 it should fail and give you an error message. > Granted, I am an approver, so I may not be seeing the same thing that > a non-approver does, but even so, I don't think an approver should be > able to stage an unapproved commit either. Maybe you can try and see if you get the error message .. if it gets staged ping me on IRC and I can unstage it :) > > Cheers, > -- > Jason Cheers, -- Sergio Ahumada Release Engineer - Digia, Qt _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
