On 29 January 2013 20:00, Sergio Ahumada <[email protected]> wrote: > On 01/29/2013 12:57 PM, Jason McDonald wrote: > > I think there is a problem here. The announcement in the link seems > > to indicate that the intention was only to present non-approvers with > > a "Merge patchset x to Staging" button once the commit has at least > > one +2. I'm now seeing the merge button on commits without any +2's, > > and even on commits where the only score is a -1. For example, see > > https://codereview.qt-project.org/#change,43299. > > > > IMO, we don't want over-eager contributors pressing that button and > > staging a change before an approver has approved it. > > I sort of remember that if you try to stage/submit a change that doesnt > have at least one +2 it should fail and give you an error message.
I see that button now all the time too (I'm not an approver). However, when I tried to stage a patch which had a +2 code review but a -1 sanity review, Gerrit gave me an error message. Haven't tried it without a +2 code review, but I presume Gerrit should complain too :) Regards, Sze-Howe _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
