On Tuesday 22 April 2014 16:43:00 Thiago Macieira wrote:
> Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> > http://macieira.org/~thiago/qt-5.3/QtSql.diff
> 
> Looks fine, if scary.


Just a little problem.

+#if QT_DEPRECATED_SINCE(5, 3)
     QSqlError( const QString& driverText = QString(),
                 const QString& databaseText = QString(),
                 ErrorType type = NoError,
                 int number = -1);
+#endif
+    QSqlError(const QString &driverText,
+              const QString &databaseText,
+              ErrorType type,
+              const QString &errorCode);

First, the deprecated constructor is missing the QT_DEPRECATED
Second, the default arguments should go on the new constructor.

-- 
Olivier 

Woboq - Qt services and support - http://woboq.com - http://code.woboq.org
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to