On 04/22/2014 11:57 PM, Sune Vuorela wrote: > On 2014-04-22, Thiago Macieira <[email protected]> wrote: >> --- a/src/network/ssl/qsslconfiguration.h >> +++ b/src/network/ssl/qsslconfiguration.h >> @@ -131,6 +132,21 @@ public: >> + static const char NextProtocolSpdy3_0[]; >> + static const char NextProtocolHttp1_1[]; > > These static const char[] kind of triggers my 'something looks wrong and > not like Qt is supposed to look like'-feeling. I haven't investigated > what they are for or how they are set and used. It just looks wrong to > me.
The static const char[]s are what we came up with to support both predefined values as well as user-defined values for negotiating the Next Protocol in the SSL handshake, see https://codereview.qt-project.org/#change,64081,patchset=5 and the following patch sets for the discussion... Peter > > /Sune > > _______________________________________________ > Development mailing list > [email protected] > http://lists.qt-project.org/mailman/listinfo/development > _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
