On Tuesday 29 July 2014 13:45:05 Milian Wolff wrote: > Hey all, > > What would happen if not all of the open review requests for the Qt > WebChannel (see [1]) repository get integrated in time for the Feature > Freeze? I'd appreciate if more people could review the things as needed so > that I can merge them as quickly as possible.
That depends. If, in the opinion of the maintainer or other relevant experts, those pending reviews are crucial for the first release, then the release blocks. Those are things like API design, API review, etc. Otherwise, those changes simply get postponed to the next release. > Once these changes are in we can finally merge the Qt WebKit [2] > integration, without which the whole Qt WebChannel module is pretty much > useless to end- users (it'd still useable but requires a lot of monkey > coding and manual websocket boiler plate code). > > I hope that we can sort this out until the Feature Freeze. If not, can I get > an exception or something or would the whole module then be dropped from > the release plan? I hope not... As it is the first release, there is some flexibility as to how important those pending changes are. Can you provide a summary of the pending reviews, in priority order? > > Bye > > [1]: https://codereview.qt-project.org/#/q/qtwebchannel+status:open,n,z > [2]: https://codereview.qt-project.org/#/c/89086/ -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
