On Wednesday 30 July 2014 17:10:50 Thiago Macieira wrote: > On Tuesday 29 July 2014 13:45:05 Milian Wolff wrote: > > Hey all, > > > > What would happen if not all of the open review requests for the Qt > > WebChannel (see [1]) repository get integrated in time for the Feature > > Freeze? I'd appreciate if more people could review the things as needed so > > that I can merge them as quickly as possible. > > That depends. If, in the opinion of the maintainer or other relevant > experts, those pending reviews are crucial for the first release, then the > release blocks. Those are things like API design, API review, etc. > > Otherwise, those changes simply get postponed to the next release.
The most important changes are now merged, I think. > > Once these changes are in we can finally merge the Qt WebKit [2] > > integration, without which the whole Qt WebChannel module is pretty much > > useless to end- users (it'd still useable but requires a lot of monkey > > coding and manual websocket boiler plate code). > > > > I hope that we can sort this out until the Feature Freeze. If not, can I > > get an exception or something or would the whole module then be dropped > > from the release plan? I hope not... > > As it is the first release, there is some flexibility as to how important > those pending changes are. > > Can you provide a summary of the pending reviews, in priority order? I think only the QtWebKit integration https://codereview.qt-project.org/#/c/89086/ and the addition of QtWebChannel as a Qt submodule https://codereview.qt-project.org/#/c/90399/ are missing right now. So I think we are on track, nice! Many thanks to everyone involved. Bye -- Milian Wolff [email protected] http://milianw.de _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
