On 11 sept. 2014, at 20:50, Thiago Macieira <[email protected]> wrote:
> On Thursday 11 September 2014 18:28:58 Samuel Gaist wrote: >> Hi, >> >> I've stumbled on https://bugreports.qt-project.org/browse/QTBUG-41190 which >> states that QtSerialPort cannot be built with Qt 4.8.6. >>> From a quick look and build, it's the use of the QT_DEPRECATED_SINCE macro >>> around the signals that makes moc miss them and thus the compilation >>> fails. >> Is there something that can be done outside of moc to workaround the problem >> ? Or does moc need to be improved ? > > NEVER #ifndef signals and slots, unless it's a simple #ifdef/#ifndef and the > #define is present in the source file being processed. > The thing is, it's not even a #ifdef, it's only a #if What would be the correct procedure to handle QT_DEPRECATED_SINCE ? Removing it from around the signal declaration would make the code a bit inconsistent. By the way, how is it handled in Qt 5 since building goes without any problem even with the macros around the signal ? _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
