On 11 sept. 2014, at 21:49, Thiago Macieira <[email protected]> wrote:
> On Thursday 11 September 2014 21:44:15 Samuel Gaist wrote: >> What would be the correct procedure to handle QT_DEPRECATED_SINCE ? Removing >> it from around the signal declaration would make the code a bit >> inconsistent. >> >> By the way, how is it handled in Qt 5 since building goes without any >> problem even with the macros around the signal ? > > moc is smarter in Qt 5: it expands macros. > > But the recommendation stands: do not #if (of any kind) anything that isn't > #defined in the same source, in a header next to the one being compiled, or > passed as -D in the command-line. > > That means: don't hide signals and slots with #if, even for deprecation. I thought I've read somewhere that moc got better at this job :-) It seems that the new moc doesn't use much of the Qt 5 only classes, would it be useful to backport it to Qt 4 to avoid having to "break" the code style for modules supporting both series ? _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
