Hi, I went through all modules now, and added my comments. Mainly small issues, with the exception of Qt 3D, where I see some real BC breakages.
Sean, could you please look at https://codereview.qt-project.org/#/c/170642/ asap. Thanks, Lars On 14/11/16 09:44, "Jani Heikkinen" <[email protected]> wrote: Hi all, It seems this is still badly ongoing, only few '+1' and only one '+2' there :( Please try to finalize the review during this week: We need to have reviews done & possible changes in '5.8' before we can start branching from '5.8' to '5.8.0' br, Jani ________________________________________ From: Edward Welbourne Sent: Monday, November 7, 2016 4:57 PM To: [email protected] Cc: Jani Heikkinen; Sune Vuorela; [email protected] Subject: Re: [Releasing] Qt 5.8.0 API review With the 5.8.0 release now close at hand, I've updated the API reviews: https://codereview.qt-project.org/170634 - qtbase https://codereview.qt-project.org/170635 - qtdeclarative https://codereview.qt-project.org/170636 - qtactiveqt https://codereview.qt-project.org/170637 - qtmultimedia https://codereview.qt-project.org/170640 - qtconnectivity https://codereview.qt-project.org/170641 - qtwayland https://codereview.qt-project.org/170642 - qt3d https://codereview.qt-project.org/170643 - qtserialbus https://codereview.qt-project.org/170644 - qtserialport https://codereview.qt-project.org/170645 - qtandroidextras https://codereview.qt-project.org/170646 - qtwebsockets https://codereview.qt-project.org/170647 - qtwebengine https://codereview.qt-project.org/170648 - qtcanvas3d https://codereview.qt-project.org/170649 - qtcharts https://codereview.qt-project.org/170650 - qtdatavis3d https://codereview.qt-project.org/170652 - qtscxml https://codereview.qt-project.org/176059 - qtquickcontrols2 Note that, although Gerrit thinks of these as proposals to change 5.8, they are actually commits based on tag v5.7.0 showing what's changed in 5.8's API, with lots of boring bits filtered out. It would be nice if some of these did in fact get reviewed ... Eddy. _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
